dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
I'm very unhappy with this change. Before I could count up all the test
failures using:
./dotest.py -v --executable $INSTALLDIR/bin/lldb 2>&1 | tee
$INSTALLDIR/lldb_test_out.log || true
lldb_failures=`grep -E "^RESULT:" lldb_test_out.log | grep failures | awk
'{count+=$5} END {print count}'` || true
lldb_errors=`grep -E "^RESULT:" lldb_test_out.log | grep errors | awk
'{count+=$7} END {print count}'` || true
lldb_passes=`grep -E "^RESULT: " lldb_test_out.log | sed 's/(//' | awk
'{count+=$3} END {print count}'` || true
lldb_total=`grep -E "^Ran [0-9]+ tests? in" lldb_test_out.log | awk
'{count+=$2} END {print count}'`
And get the correct totals:
lldb_failures=2
lldb_errors=0
lldb_passes=1143
lldb_total=1376
Now it seems we are back to the broken behavior of dosep.py where there's no
way to count the correct totals since it seems to forget to count 25% of the
test results. Only now I have no workaround, because even dotest.py can't
report the changes correctly. Please revert this so I can use dosep.py as
before, or fix dotest.py to count correctly.
Thank you,
-Dawn
Users:
tfiala (Author)
dawn (Auditor)
http://reviews.llvm.org/rL246794
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
