Re: [Lldb-commits] [PATCH] D12672: add a dependency on terminfo library if llvm uses it

[Jeremi Piotrowski via lldb-commits]

jeremi.piotrowski updated this revision to Diff 34169.
jeremi.piotrowski added a comment.

- combine nested if conditions with `and` as suggested by zturner

  and remove condtition from `endif` as that seems to be the convention.


http://reviews.llvm.org/D12672

Files:
  cmake/LLDBDependencies.cmake

Index: cmake/LLDBDependencies.cmake
===================================================================
--- cmake/LLDBDependencies.cmake
+++ cmake/LLDBDependencies.cmake
@@ -146,6 +146,9 @@
   endif()
   if (NOT LLDB_DISABLE_CURSES)
     list(APPEND LLDB_SYSTEM_LIBS panel ncurses)
+    if(LLVM_ENABLE_TERMINFO AND HAVE_TERMINFO)
+      list(APPEND LLDB_SYSTEM_LIBS ${TERMINFO_LIBS})
+    endif()
   endif()
 endif()
 # On FreeBSD backtrace() is provided by libexecinfo, not libc.



Index: cmake/LLDBDependencies.cmake
===================================================================
--- cmake/LLDBDependencies.cmake
+++ cmake/LLDBDependencies.cmake
@@ -146,6 +146,9 @@
   endif()
   if (NOT LLDB_DISABLE_CURSES)
     list(APPEND LLDB_SYSTEM_LIBS panel ncurses)
+    if(LLVM_ENABLE_TERMINFO AND HAVE_TERMINFO)
+      list(APPEND LLDB_SYSTEM_LIBS ${TERMINFO_LIBS})
+    endif()
   endif()
 endif()
 # On FreeBSD backtrace() is provided by libexecinfo, not libc.

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits