clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
One minor IsValid() fix in DWARFDIE to avoid crashes and this is good to go.
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp:28-35
@@ -27,1 +27,10 @@
+DIERef
+DWARFDIE::GetDIERef() const
+{
+ dw_offset_t cu_offset = m_cu->GetOffset();
+ if (m_cu->GetBaseObjOffset() != DW_INVALID_OFFSET)
+ cu_offset = m_cu->GetBaseObjOffset();
+ return DIERef(cu_offset, m_die->GetOffset());
+}
+
----------------
Need to check IsValid() first and place all above code inside the if and have
the else return a DIERef().
http://reviews.llvm.org/D12291
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
