If the patch is busted, pretty much every test should start failing. As long as ninja check-lldb actually runs, completes, and behaves pretty much the same way as before, that's pretty much all that needs to be verified.
Ctrl+C shouldn't behave any differently with this patch, the idea was to refactor it so that on Windows it would be identical to pre-patch, but on other platforms there would be improved Ctrl+C handling On Tue, Sep 8, 2015 at 1:08 PM Adrian McCarthy <amcca...@google.com> wrote: > amccarth added a subscriber: amccarth. > amccarth added a comment. > > After applying the patch, I get three additional test case failures on > Windows. I'm trying to figure out now which ones. > > Is there something specific I'm supposed to be trying, with regard to > Ctrl+C itself. > > > http://reviews.llvm.org/D12651 > > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
