jaydeep added a comment.

In http://reviews.llvm.org/D12079#242742, @clayborg wrote:

> So DumpAddress() in FormatEntity.cpp is a generic "dump any address by 
> describing it". You can't just change the code to suit your needs for MIPS. 
> This address could be any address: code or data. If you want something that 
> can take an address like 0x1000 and you ask for its AddressClass and it sees 
> that its address class is eAddressClassCodeAlternateISA, and then you change 
> it to be "0x1001", this will need to be a new format type.
>
> DumpAddress in FormatEntity.cpp is called for the following entities:
>
>   case Entry::Type::LineEntryStartAddress:
>   case Entry::Type::LineEntryEndAddress:
>   case Entry::Type::AddressFile:
>   case Entry::Type::AddressLoad:
>   case Entry::Type::AddressLoadOrFile:
>   case Entry::Type::FrameRegisterPC
>   
>
> So only the LineEntry ones should actually do what you did.


We need to display all these entities in compressed address format. How about a 
new MIPS specific function in Address and Target class which would do this.

Address Address::GetCallableAddress(Target *target);
lldb::addr_t Target::GetCallableAddress (lldb::addr_t load_addr, AddressClass 
addr_class);


Repository:
  rL LLVM

http://reviews.llvm.org/D12079



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to