Author: labath Date: Wed Sep 16 05:27:57 2015 New Revision: 247783 URL: http://llvm.org/viewvc/llvm-project?rev=247783&view=rev Log: Revert "[LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo"
This reverts commit r247773, because it breaks remote debugging support for lldb-server. Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp?rev=247783&r1=247782&r2=247783&view=diff ============================================================================== --- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp (original) +++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp Wed Sep 16 05:27:57 2015 @@ -3396,17 +3396,6 @@ GDBRemoteCommunicationClient::SetCurrent m_curr_tid = tid; return true; } - - /* - * Connected bare-iron target (like YAMON gdb-stub) may not have support for Hg packet. - * The reply from '?' packet could be as simple as 'S05'. There is no packet which can - * give us pid and/or tid. Assume pid=tid=1 in such cases. - */ - if (!response.IsNormalResponse() && IsConnected()) - { - m_curr_tid = 1; - return true; - } } return false; } @@ -3433,17 +3422,6 @@ GDBRemoteCommunicationClient::SetCurrent m_curr_tid_run = tid; return true; } - - /* - * Connected bare-iron target (like YAMON gdb-stub) may not have support for Hc packet. - * The reply from '?' packet could be as simple as 'S05'. There is no packet which can - * give us pid and/or tid. Assume pid=tid=1 in such cases. - */ - if (!response.IsNormalResponse() && IsConnected()) - { - m_curr_tid_run = 1; - return true; - } } return false; } @@ -3569,17 +3547,6 @@ GDBRemoteCommunicationClient::GetCurrent } while (ch == ','); // Make sure we got a comma separator } } - - /* - * Connected bare-iron target (like YAMON gdb-stub) may not have support for - * qProcessInfo, qC and qfThreadInfo packets. The reply from '?' packet could - * be as simple as 'S05'. There is no packet which can give us pid and/or tid. - * Assume pid=tid=1 in such cases. - */ - if (!response.IsNormalResponse() && thread_ids.size() == 0 && IsConnected()) - { - thread_ids.push_back (1); - } } else { _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits