Ok, lgtm then On Fri, Sep 18, 2015 at 10:42 AM Oleksiy Vyalov <ovya...@google.com> wrote:
> ovyalov added inline comments. > > ================ > Comment at: source/Host/windows/FileSystem.cpp:130 > @@ +129,3 @@ > + HANDLE file_handle = ::CreateFile(file_spec.GetCString(), > + FILE_READ_ATTRIBUTES, > + FILE_SHARE_READ, > ---------------- > Thanks for suggestion - it does work. Fixed. > > ================ > Comment at: source/Utility/ModuleCache.cpp:110 > @@ +109,3 @@ > + > + if (link_count > 2) // module is referred by other hosts. > + return; > ---------------- > If link counter == 2, it's okay to delete a module because in this case a > counter includes following files: $platform/.cache/$uuid and its sysroot > link. > > > http://reviews.llvm.org/D12971 > > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
