krytarowski added inline comments. ================ Comment at: include/lldb/Config/config.h.cmake:6 @@ +5,3 @@ +#else +#define CONFIG_H + ---------------- krytarowski wrote: > brucem wrote: > > brucem wrote: > > > This should be `LLDB_CONFIG_CONFIG_H` rather than just `CONFIG_H`. > > > > > > Also, why not use the same `#ifndef` technique that everything else uses > > > in the header files? > > Also, other headers in LLDB tend to have capitalized names, so maybe this > > should be `include/lldb/Config/Config.h.cmake`. > I was following the clang/llvm approach of exclusing llvm's config.h and > subprojects' one. Please have a look at: https://github.com/llvm-mirror/clang/tree/master/include/clang/Config
Repository: rL LLVM http://reviews.llvm.org/D12994 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
