zturner added a comment.

This looks great.  This has always really annoyed me.  One thing I want to 
point out based on your summary of the patch.  A user *must* build Python 
himself, even if he is building a release version of LLDB.  You *cannot* use 
the version that is installed on the system.  The reason is because the release 
python on python.org is compiled with VC 2008, and LLDB is compiled with VC 
2013.  The two CRTs are ABI incompatible so you'll get heap corruption and 
other strange errors if you don't build Python yourself.

Patch looks fine though


Repository:
  rL LLVM

http://reviews.llvm.org/D13237



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to