brucem added a subscriber: brucem. brucem added a comment. Unless someone else (@emaste?) objects, I think this looks fine to land and iterate on trunk as discussed in the mailing list thread. Just one minor comment based on cleanups that are on-going on trunk now.
================ Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.h:50 @@ +49,3 @@ + virtual + ~PlatformNetBSD(); + ---------------- Might as well change this to `~PlatformNetBSD () override = default;` I think. Repository: rL LLVM http://reviews.llvm.org/D13334 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
