clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Looks good. The other way to do this would be to add a key/value pair to the 
qHostInfo like "memory_cache_line_byte_size" and return a value that makes 
sense for the current Andriod debug target. Why? This change will hard code any 
android target to use 4K packets. In the future if you have a watch or other 
Android device that has slow communication, it might be nice to be able to 
control this by modifying the lldb-server so this can be controlled at a finer 
level. Just something to think about.


http://reviews.llvm.org/D13812



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to