ovyalov accepted this revision.
ovyalov added a comment.
Looks good - minor comments.
================
Comment at:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:513
@@ +512,3 @@
+ {
+ FileSpec file_spec;
+ file_spec.SetFile("[vdso]", false);
----------------
Please combine these 2 lines - FileSpec file_spec("[vdso]", false);
================
Comment at: test/functionalities/inferior-assert/TestInferiorAssert.py:161
@@ -162,1 +160,3 @@
pc_backup_offset = 0
+ if "i386" in self.getArchitecture():
+ if lastframeID == frame.GetFrameID():
----------------
Could you store result of "i386" in self.getArchitecture() as temp variable
outside of frames's loop?
http://reviews.llvm.org/D14118
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
