brucem added a subscriber: brucem. brucem requested changes to this revision. brucem added a reviewer: brucem.
================ Comment at: tools/lldb/source/Host/linux/HostThreadLinux.cpp:33 @@ -32,3 +32,3 @@ { -#if (defined(__GLIBC__) && defined(_GNU_SOURCE)) || defined(__ANDROID__) +#if (defined(__GLIBC__) && defined(_GNU_SOURCE) && __GLIBC__ >= 2 && __GLIBC_MINOR__ >= 12) || defined(__ANDROID__) ::pthread_setname_np(thread, name.data()); ---------------- This is probably better done with weak symbols or a check in configure and cmake rather than hard-coding this stuff in the C pre-processor. ================ Comment at: tools/lldb/source/Host/posix/PipePosix.cpp:32 @@ -31,1 +31,3 @@ +#include <linux/version.h> + ---------------- krytarowski wrote: > Is this file just for Linux? This file isn't Linux only, so the concerns expressed by Labath are valid here as well. (The same thing is true of other inclusions of `<linux/version.h>`.) ================ Comment at: tools/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:72 @@ -71,1 +71,3 @@ +// Missing defines due to bug: https://sourceware.org/bugzilla/show_bug.cgi?id=4125 + ---------------- This bug was fixed in 2007, over 8 years ago ... at what point do we stop carrying around this baggage? Repository: rL LLVM http://reviews.llvm.org/D14182 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits