labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Nice catch. Looks good.
================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3516
@@ -3544,1 +3515,3 @@
Error
+ProcessGDBRemote::CheckDebugserverConnection (const ProcessInfo &process_info)
+{
----------------
I find this name somewhat misleading. `Check` would generally imply a read-only
operation, but this actually establishes the connection in some circumstances.
I'd go for `EstablishConnectionIfNeeded` or something like that.
http://reviews.llvm.org/D14895
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
