joerg added a comment.
Two small cleanups, otherwise LGTM.
================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1328
@@ -1313,3 +1327,3 @@
cls.platformContext = _PlatformContext('DYLD_LIBRARY_PATH', 'lib',
'dylib')
- elif getPlatform() == "linux" or getPlatform() == "freebsd":
+ elif getPlatform() == "linux" or getPlatform() == "freebsd" or
getPlatform() == "netbsd":
cls.platformContext = _PlatformContext('LD_LIBRARY_PATH', 'lib',
'so')
----------------
I'd prefer `getPlatform() in ("linux", "freebsd", "netbsd")` as more shorter.
================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:2288
@@ -2271,3 +2287,3 @@
def getLibcPlusPlusLibs(self):
- if self.getPlatform() == 'freebsd' or self.getPlatform() == 'linux':
+ if self.getPlatform() == 'freebsd' or self.getPlatform() == 'linux' or
self.getPlatform() == 'netbsd':
return ['libc++.so.1']
----------------
Same, `self.getPlatform in ...`
Repository:
rL LLVM
http://reviews.llvm.org/D15262
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
