tberghammer created this revision.
tberghammer added reviewers: tfiala, endlessroad, loladiro.
tberghammer added a subscriber: lldb-commits.
Don't pack the structs of the jit debug interface
None of the documentation mentions that the entries are packed structs and also
none of the other implementation I found pack them.
LLVM implementation:
https://github.com/llvm-mirror/llvm/blob/master/lib/ExecutionEngine/GDBRegistrationListener.cpp
http://reviews.llvm.org/D15715
Files:
source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
Index: source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
===================================================================
--- source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
+++ source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
@@ -90,7 +90,6 @@
JIT_UNREGISTER_FN
} jit_actions_t;
-#pragma pack(push, 4)
template <typename ptr_t>
struct jit_code_entry
{
@@ -107,7 +106,6 @@
ptr_t relevant_entry; // pointer
ptr_t first_entry; // pointer
};
-#pragma pack(pop)
JITLoaderGDB::JITLoaderGDB (lldb_private::Process *process) :
JITLoader(process),
Index: source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
===================================================================
--- source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
+++ source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
@@ -90,7 +90,6 @@
JIT_UNREGISTER_FN
} jit_actions_t;
-#pragma pack(push, 4)
template <typename ptr_t>
struct jit_code_entry
{
@@ -107,7 +106,6 @@
ptr_t relevant_entry; // pointer
ptr_t first_entry; // pointer
};
-#pragma pack(pop)
JITLoaderGDB::JITLoaderGDB (lldb_private::Process *process) :
JITLoader(process),
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
