zturner added a subscriber: zturner. zturner added a comment. Perhaps a middle ground to these two sides could be something along the lines of "If you're going to make sweeping changes to remove a particular feature from a set of tests, make sure there's a reasonable amount of isolated coverage of the thing you're removing".
Honestly though, our culture of testing really needs to imrpove at the larger scale going forward. We need more tests, and we need to start blocking or reverting CLs that don't have some amount test coverage. A common one that I see is "well this is just putting some infrastructure in place that isn't being used anywhere yet". But even that is still testable. That's exactly what unit tests, mock implementations, and dependency injection are for. http://reviews.llvm.org/D16334 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
