tfiala added a comment. In http://reviews.llvm.org/D16508#334452, @krytarowski wrote:
> @tfiala thank you for your verbose and quick feedback. It made the things > more clear! My pleasure! > While I'm processing your reply -- a question, does it matter whether we > define GPR as signed or unsigned integers? Is it platform specific part too? > Should I change this to `uint64_t`? I don't remember off the top of my head. I'll have a look later when I can get to the code. For starters, though, I would follow whatever the Linux and OS X ones do for this as it shouldn't be too different than that. (My first guess would be we just treat them as unsigned bytes at the raw level, and then adjust them as needed based on what data types we think are specified in the registers, but I could be wrong.) Repository: rL LLVM http://reviews.llvm.org/D16508 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
