granata.enrico added a comment.

That seems reasonable, yes.

In general, I wish I had done this not via two strings - only one of which gets 
to be valid in some arbitrary order - but via either two distinct subclasses, 
or at least via a pair of a string and an enum class specifying the kind.

But that is clearly beyond the scope of you fixing this test case. Your change 
is fine.


Repository:
  rL LLVM

http://reviews.llvm.org/D16703



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to