zturner added inline comments.

================
Comment at: source/Core/ConstString.cpp:269
@@ +268,3 @@
+bool
+ConstString::Equals (const ConstString& lhs, const ConstString& rhs, const 
bool case_sensitive)
+{
----------------
labath wrote:
> zturner wrote:
> > Looks like this code also isn't clang-formatted.  If you build clang-format 
> > (with `ninja clang-format`) and add its folder to your `PATH` environment 
> > variable, then when your changes are staged in git, just run `git 
> > clang-format`.
> > 
> > If you've already committed you can uncommit with `git reset --soft HEAD`.  
> > Then they will be staged again, then you can run `git clang-format`, then 
> > re-add all the modified files, and then recommit.
> Or, you can use `git clang-format rev` to format all changes since `rev` (you 
> probably want `rev`=`HEAD^`).
> 
> </drive-by>
Neat, didn't know about this.  (although on Windows you have to use either 
HEAD~1 or HEAD^^, since ^ needs to be escaped.  This makes it particularly 
annoying if you want HEAD~2 for example, because then you need HEAD^^^^, etc.  
So most people on windows use the ~n syntax.


http://reviews.llvm.org/D17492



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to