tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good (it would be nice if we can split GetReturnValueObjectImpl to
multiple function as it starts to become pretty big and hard to read but I
don't think we shouldn't do it as part of this CL)
================
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:586-588
@@ -576,3 +585,5 @@
}
else
{
+ if (is_complex && float_count == 2)
+ {
----------------
(nit): It can be an "else if"
================
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:599-601
@@ -579,3 +598,5 @@
+ }
+ else
// not handled yet
return return_valobj_sp;
}
----------------
(nit); Indentation
http://reviews.llvm.org/D17708
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
