zturner added a comment. Can you rebase against tip of trunk? I want to apply and run the test suite with the patch applied, but I'm getting a lot of errors. After uploading a new rebased patch, can you also respond with the revision you rebased against so I can make sure I'm at the same place.
================ Comment at: lldb/trunk/source/Host/common/File.cpp:330 @@ +329,3 @@ + } + ::_wsopen_s(&m_descriptor, wpath.c_str(), oflag, _SH_DENYWR, mode); +#else ---------------- Any particular reason you're using `_SH_DENYWR` instead of `_SH_DENYNO`? No matter what we do we will always have subtle differences in semantics, but `_SH_DENYNO` is closer to posix semantics. http://reviews.llvm.org/D17107 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
