clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just a few questions on why read watchpoints were being disabled in the few
SBValue::Watch() calls. Other than that it looks good. Is it possible to revert
the read watchpoint changes, or is it needed for SystemZ?
================
Comment at:
packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_events/TestWatchpointEvents.py:62
@@ -61,3 +61,3 @@
error = lldb.SBError()
- local_watch = local_var.Watch(True, True, True, error)
+ local_watch = local_var.Watch(True, False, True, error)
if not error.Success():
----------------
I realize this test isn't actually using the watchpoint, it is just testing it,
but why is this change needed? Does SystemZ not support read watchpoints or
something?
================
Comment at:
packages/Python/lldbsuite/test/python_api/watchpoint/TestWatchpointIter.py:61
@@ -60,3 +60,3 @@
error = lldb.SBError();
- watchpoint = value.Watch(True, True, True, error)
+ watchpoint = value.Watch(True, False, True, error)
self.assertTrue(value and watchpoint,
----------------
This test just tests hitting writes to a variable, but why is this change
needed? Does SystemZ not support read watchpoints or something?
http://reviews.llvm.org/D18978
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
