omjavaid added a comment.
Seems legit but One cosmetic comment inline.
Also have you tested this patch by running LLDB testsuite on arm in both little
and big endian modes?
================
Comment at: source/Plugins/Instruction/ARM/EmulationStateARM.cpp:157
@@ -149,12 +156,3 @@
{
- if (size > 8)
- return false;
-
- if (size <= 4)
- m_memory[p_address] = value;
- else if (size == 8)
- {
- m_memory[p_address] = (value << 32) >> 32;
- m_memory[p_address + 4] = value << 32;
- }
+ m_memory[p_address] = value;
return true;
----------------
m_memory is a map with map type uint32? I think we will end up loosing data
here if its larger than 4 bytes. if StoreToPseudoAddress isnt used elsewhere
better change value from uint64 to uint32 ? Also size seems to be a redundant
argument now.
http://reviews.llvm.org/D18984
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
