Ahh that's unfortunate. I guess the thing to do is make SetFile and SetDirectory. At least by changing the return type we can get the compiler to tell us everywhere this is happening. Did you run the test suite on Windows to make sure this doesnt break anything? On Wed, Apr 13, 2016 at 8:36 AM Pavel Labath <lab...@google.com> wrote:
> labath added a comment. > > It's a bit more complicated than it seems. GetDirectory() returns a > reference into the FileSpec, and a lot of code modifies it through it. > Changing that would require fixups in all of the users, which I'd want to > do separately. > > But I do agree that this is the best way forward. > > > http://reviews.llvm.org/D19060 > > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
