labath added a comment.

Good question. I don't really have an opinion on that... Is it just that single 
line? (this would be simpler if you uploaded the final version :) ). If it just 
that single line, then I think it's fine. If you also need to play with the 
ADDITIONAL_VERSIONS and such, then we should think about making a macro or 
doing something else to avoid code duplication (there is already a FIXME in 
scripts/Python/modules/readline mentioning the additional versions).


Repository:
  rL LLVM

http://reviews.llvm.org/D15067



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to