OK, i see. Thanks for the explanation. This may actually be some windows specific thing then, as I remember zachary mentioning they have some flakyness issues there.
BTW, this has sped up the LLDB test suite nearly 2x, so thanks a lot for that. :) pl On 14 June 2016 at 17:13, Cameron <came...@moodycamel.com> wrote: > cameron314 added a comment. > > Thanks everyone :-) > > Ah, yeah, sorry if I gave the wrong impression, but that comment is not > specific to Linux (in fact, I've only seen it once, on Windows). At one point > the debugger had entered ControlPrivateStateThread on one thread to stop it, > seen that the thread was already in an invalid state (it was), and assumed > that meant that the thread was already exiting and did a join without sending > the stop. But the state thread somehow wasn't on its way out yet, it was > stuck waiting for a control event first (this is the part that I'm not sure > should be possible, but empirically is). This caused a deadlock. So I changed > my patch to always send the event if the thread is joinable, not just if its > state is valid, and left that comment to explain why this must remain so. > > > http://reviews.llvm.org/D21296 > > > _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
