This revision was automatically updated to reflect the committed changes. Closed by commit rL277016: Cleanup some format string warnings (authored by ldrumm).
Changed prior to commit: https://reviews.llvm.org/D22923?vs=65941&id=65960#toc Repository: rL LLVM https://reviews.llvm.org/D22923 Files: lldb/trunk/source/Core/ValueObjectSyntheticFilter.cpp Index: lldb/trunk/source/Core/ValueObjectSyntheticFilter.cpp =================================================================== --- lldb/trunk/source/Core/ValueObjectSyntheticFilter.cpp +++ lldb/trunk/source/Core/ValueObjectSyntheticFilter.cpp @@ -271,12 +271,11 @@ idx); lldb::ValueObjectSP synth_guy = m_synth_filter_ap->GetChildAtIndex (idx); - + if (log) - log->Printf("[ValueObjectSynthetic::GetChildAtIndex] name=%s, child at index %zu created as %p (is synthetic: %s)", - GetName().AsCString(), - idx, - synth_guy.get(), + log->Printf("[ValueObjectSynthetic::GetChildAtIndex] name=%s, child at index %zu created as %p (is " + "synthetic: %s)", + GetName().AsCString(), idx, static_cast<void *>(synth_guy.get()), synth_guy.get() ? (synth_guy->IsSyntheticChildrenGenerated() ? "yes" : "no") : "no"); if (!synth_guy) @@ -291,22 +290,19 @@ else { if (log) - log->Printf("[ValueObjectSynthetic::GetChildAtIndex] name=%s, child at index %zu not cached and cannot be created (can_create = %s, synth_filter = %p)", - GetName().AsCString(), - idx, - can_create ? "yes" : "no", - m_synth_filter_ap.get()); + log->Printf("[ValueObjectSynthetic::GetChildAtIndex] name=%s, child at index %zu not cached and cannot " + "be created (can_create = %s, synth_filter = %p)", + GetName().AsCString(), idx, can_create ? "yes" : "no", + static_cast<void *>(m_synth_filter_ap.get())); return lldb::ValueObjectSP(); } } else { if (log) log->Printf("[ValueObjectSynthetic::GetChildAtIndex] name=%s, child at index %zu cached as %p", - GetName().AsCString(), - idx, - valobj); + GetName().AsCString(), idx, static_cast<void *>(valobj)); return valobj->GetSP(); }
Index: lldb/trunk/source/Core/ValueObjectSyntheticFilter.cpp =================================================================== --- lldb/trunk/source/Core/ValueObjectSyntheticFilter.cpp +++ lldb/trunk/source/Core/ValueObjectSyntheticFilter.cpp @@ -271,12 +271,11 @@ idx); lldb::ValueObjectSP synth_guy = m_synth_filter_ap->GetChildAtIndex (idx); - + if (log) - log->Printf("[ValueObjectSynthetic::GetChildAtIndex] name=%s, child at index %zu created as %p (is synthetic: %s)", - GetName().AsCString(), - idx, - synth_guy.get(), + log->Printf("[ValueObjectSynthetic::GetChildAtIndex] name=%s, child at index %zu created as %p (is " + "synthetic: %s)", + GetName().AsCString(), idx, static_cast<void *>(synth_guy.get()), synth_guy.get() ? (synth_guy->IsSyntheticChildrenGenerated() ? "yes" : "no") : "no"); if (!synth_guy) @@ -291,22 +290,19 @@ else { if (log) - log->Printf("[ValueObjectSynthetic::GetChildAtIndex] name=%s, child at index %zu not cached and cannot be created (can_create = %s, synth_filter = %p)", - GetName().AsCString(), - idx, - can_create ? "yes" : "no", - m_synth_filter_ap.get()); + log->Printf("[ValueObjectSynthetic::GetChildAtIndex] name=%s, child at index %zu not cached and cannot " + "be created (can_create = %s, synth_filter = %p)", + GetName().AsCString(), idx, can_create ? "yes" : "no", + static_cast<void *>(m_synth_filter_ap.get())); return lldb::ValueObjectSP(); } } else { if (log) log->Printf("[ValueObjectSynthetic::GetChildAtIndex] name=%s, child at index %zu cached as %p", - GetName().AsCString(), - idx, - valobj); + GetName().AsCString(), idx, static_cast<void *>(valobj)); return valobj->GetSP(); }
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits