labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I have a couple of questions I'd like to be answered before this goes in. Apart
from the inline comments, all my questions from the previous version of this
commit still stand.
================
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:5
@@ +4,3 @@
+
+ifeq "$(ARCH)" "i386"
+ CXXFLAGS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32
----------------
This should not be necessary. Makefile.rules already correctly appends -m32
when needed. Maybe CFLAGS_EXTRAS would work instead (?)
================
Comment at:
packages/Python/lldbsuite/test/functionalities/register/register_command/TestRegisters.py:297
@@ -294,4 +296,3 @@
for registerSet in registerSets:
- if 'advanced vector extensions' in
registerSet.GetName().lower():
- has_avx = True
- break
+ if registerSet.GetName():
+ if 'advanced vector extensions' in
registerSet.GetName().lower():
----------------
Do we want to allow a register set with no name? It looks like the root of the
problem is elsewhere.
https://reviews.llvm.org/D24255
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
