krytarowski added a comment. In https://reviews.llvm.org/D23883#539471, @mgorny wrote:
> In https://reviews.llvm.org/D23883#539442, @krytarowski wrote: > > > It looks good. Remaining TODO for standalone builds: > > > > - sanitize six.py usage (it's installed into system-wide directory, where > > standard py-six lands) > > > How would you prefer handling it? Can we just kill it and rely on user > installing it system-wide or via pip? 1. Patch scripts/Python/finishSwigPythonLLDB.py and install six into lldb subdir with a custom name (`lldb_six.py`). 2. Patch the Python sources to make use of `lldb_six`. Unfortunately there is resistance to grab system-wide (provided by a user) six module. > > - bump cmake_minimum_required(VERSION 2.8.12.2) to 3.4.3 in > > cmake/modules/LLDBStandalone.cmake Final bits for Windows: > > > - eliminate the usage of ../lib/Support/regex_impl.h in RegularExpression.h > > > Wouldn't it be actually better to kill that regex implementation as well, and > use the class provided by LLVMSupport everywhere? I started with the other > since it caused direct build issues on Linux but I think I could try to kill > this one as well. It makes sense. https://reviews.llvm.org/D23883 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits