Michael137 wrote:

Yea I agree, I think this makes things easier to reason about. And if the 
"no-DW_AT_byte_size on definition" case comes up, that can be addressed 
differently.

> We could do that, but then we'd also need to do that in 
> ParseStructureLikeDIE. And we may need to figure out what does it mean to 
> occupy a non-whole number of bytes, so I'd say that's orthogonal to this.

Yup, since it wasn't there before, happy to defer it.

> The problem is really specific to this place in the code, where we've already 
> completed the clang type, but we haven't created the layout for it.

Ack

https://github.com/llvm/llvm-project/pull/110648
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to