clayborg added a comment.

Please comment why you are manually bit twiddling due to the size of the 
register that can change. We don't want anyone else copying this kind of code. 
Another solution would be to update the offset of the register when you change 
the byte size so none of this would need to be done. We are already updating 
the byte size of the register in the RegisterInfo, so why not do the same for 
the offset. You could store the original offset in the 
RegisterInfo.kinds[eRegisterKindProcessPlugin] as this field is only for the 
process plug-in's use.


https://reviews.llvm.org/D24603



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to