clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed.
Use "llvm::StringRef::contains". See inline comment. ================ Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1408-1409 llvm::StringRef path(cstr); - if (path.startswith("/lib/x86_64-linux-gnu") || - path.startswith("/lib/i386-linux-gnu")) { + if (path.find("/lib/x86_64-linux-gnu") != llvm::StringRef::npos || + path.find("/lib/i386-linux-gnu") != llvm::StringRef::npos) { arch_spec.GetTriple().setOS(llvm::Triple::OSType::Linux); ---------------- I believe Zach Turner added a "contains" function to StringRef which we should use here: ``` if (path.contains("/lib/x86_64-linux-gnu") || path.contains("/lib/i386-linux-gnu")) { ``` https://reviews.llvm.org/D25179 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits