[Lldb-commits] [PATCH] debugserver: Remove an infinitely recursive operator=

[Justin Bogner via lldb-commits]

Today I checked out lldb to check that r284364 wouldn't cause any
trouble, but there were a few warnings that fired when I tried to build
it, breaking my -Werror build.

This deletes an unused operator= that would infinitely recurse if it
were called (caught by -Winfinite-recursion). It would also probably be
reasonable to `= default` this or do a memberwise assignment, if you
prefer.


commit 5522eaf39ab8ed9f44c62c212b71cd37582e1668
Author: Justin Bogner <m...@justinbogner.com>
Date:   Sun Oct 16 21:39:48 2016 -0700

    debugserver: Remove an infinitely recursive operator=

diff --git a/tools/debugserver/source/MacOSX/CFBundle.cpp b/tools/debugserver/source/MacOSX/CFBundle.cpp
index 7b080e6..060b3c7 100644
--- a/tools/debugserver/source/MacOSX/CFBundle.cpp
+++ b/tools/debugserver/source/MacOSX/CFBundle.cpp
@@ -30,14 +30,6 @@ CFBundle::CFBundle(const CFBundle &rhs)
     : CFReleaser<CFBundleRef>(rhs), m_bundle_url(rhs.m_bundle_url) {}

 //----------------------------------------------------------------------
-// CFBundle copy constructor
-//----------------------------------------------------------------------
-CFBundle &CFBundle::operator=(const CFBundle &rhs) {
-  *this = rhs;
-  return *this;
-}
-
-//----------------------------------------------------------------------
 // Destructor
 //----------------------------------------------------------------------
 CFBundle::~CFBundle() {}
diff --git a/tools/debugserver/source/MacOSX/CFBundle.h b/tools/debugserver/source/MacOSX/CFBundle.h
index 09957af..c0aa35a 100644
--- a/tools/debugserver/source/MacOSX/CFBundle.h
+++ b/tools/debugserver/source/MacOSX/CFBundle.h
@@ -23,7 +23,7 @@ public:
   //------------------------------------------------------------------
   CFBundle(const char *path = NULL);
   CFBundle(const CFBundle &rhs);
-  CFBundle &operator=(const CFBundle &rhs);
+  CFBundle &operator=(const CFBundle &rhs) = delete;
   virtual ~CFBundle();
   bool SetPath(const char *path);

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits