Author: jingham Date: Tue Oct 25 20:09:21 2016 New Revision: 285153 URL: http://llvm.org/viewvc/llvm-project?rev=285153&view=rev Log: SBWatchpoint::Disable doesn't actually work. Add a test that shows this.
Next to fix it! Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/ lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/Makefile lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/TestWatchpointDisable.py lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/main.c Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/Makefile URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/Makefile?rev=285153&view=auto ============================================================================== --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/Makefile (added) +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/Makefile Tue Oct 25 20:09:21 2016 @@ -0,0 +1,5 @@ +LEVEL = ../../../make + +C_SOURCES := main.c + +include $(LEVEL)/Makefile.rules Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/TestWatchpointDisable.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/TestWatchpointDisable.py?rev=285153&view=auto ============================================================================== --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/TestWatchpointDisable.py (added) +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/TestWatchpointDisable.py Tue Oct 25 20:09:21 2016 @@ -0,0 +1,75 @@ +""" +Test that the SBWatchpoint::SetEnable API works. +""" + +import os +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.decorators import * +from lldbsuite.test import lldbplatform, lldbplatformutil + + +class TestWatchpointSetEnable(TestBase): + mydir = TestBase.compute_mydir(__file__) + + def setUp(self): + # Call super's setUp(). + TestBase.setUp(self) + + # Watchpoints not supported + @expectedFailureAndroid(archs=['arm', 'aarch64']) + @expectedFailureAll( + oslist=["windows"], + bugnumber="llvm.org/pr24446: WINDOWS XFAIL TRIAGE - Watchpoints not supported on Windows") + @expectedFailureAll(bugnumber="llvm.org/pr30789, <rdar://problem/28944061>") + def test_disable_works (self): + """Set a watchpoint, disable it, and make sure it doesn't get hit.""" + self.build() + self.disable_works() + + def disable_works(self): + """Set a watchpoint, disable it and make sure it doesn't get hit.""" + + exe = 'a.out' + + exe = os.path.join(os.getcwd(), exe) + main_file_spec = lldb.SBFileSpec("main.c") + + # Create a target by the debugger. + self.target = self.dbg.CreateTarget(exe) + self.assertTrue(self.target, VALID_TARGET) + cwd = os.getcwd() + + + bkpt_before = self.target.BreakpointCreateBySourceRegex("Set a breakpoint here", main_file_spec) + self.assertEqual(bkpt_before.GetNumLocations(), 1, "Failed setting the before breakpoint.") + + bkpt_after = self.target.BreakpointCreateBySourceRegex("We should have stopped", main_file_spec) + self.assertEqual(bkpt_after.GetNumLocations(), 1, "Failed setting the after breakpoint.") + + process = self.target.LaunchSimple( + None, None, self.get_process_working_directory()) + self.assertTrue(process, PROCESS_IS_VALID) + + thread = lldbutil.get_one_thread_stopped_at_breakpoint(process, bkpt_before) + self.assertTrue(thread.IsValid(), "We didn't stop at the before breakpoint.") + + ret_val = lldb.SBCommandReturnObject() + self.dbg.GetCommandInterpreter().HandleCommand("watchpoint set variable -w write global_var", ret_val) + self.assertTrue(ret_val.Succeeded(), "Watchpoint set variable did not return success.") + + wp = self.target.FindWatchpointByID(1) + self.assertTrue(wp.IsValid(), "Didn't make a valid watchpoint.") + self.assertTrue(wp.GetWatchAddress() != lldb.LLDB_INVALID_ADDRESS, "Watch address is invalid") + + wp.SetEnabled(False) + self.assertTrue(not wp.IsEnabled(), "The watchpoint thinks it is still enabled") + + process.Continue() + + stop_reason = thread.GetStopReason() + + self.assertEqual(stop_reason, lldb.eStopReasonWatchpoint, "We didn't stop at our watchpoint.") + + + Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/main.c URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/main.c?rev=285153&view=auto ============================================================================== --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/main.c (added) +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_disable/main.c Tue Oct 25 20:09:21 2016 @@ -0,0 +1,12 @@ +#include <stdio.h> + +int global_var = 10; + +int +main() +{ + printf("Set a breakpoint here: %d.\n", global_var); + global_var = 20; + printf("We should have stopped on the previous line: %d.\n", global_var); + return 0; +} _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits