Author: tfiala Date: Fri Nov 11 15:06:40 2016 New Revision: 286631 URL: http://llvm.org/viewvc/llvm-project?rev=286631&view=rev Log: Remove weak-linked symbols for SBBreakpointListImpl
Summary: Similar to SBStructuredData's Impl class, SBBreakpointListImpl was getting weak-link exported in the lldb namespace. This change list fixes that by moving out of the lldb public namespace, which removes it from public export visibility. Fixes: rdar://28960344 Reviewers: jingham Subscribers: lldb-commits Differential Revision: https://reviews.llvm.org/D26553 Modified: lldb/trunk/include/lldb/API/SBBreakpoint.h lldb/trunk/include/lldb/API/SBTarget.h lldb/trunk/source/API/SBBreakpoint.cpp Modified: lldb/trunk/include/lldb/API/SBBreakpoint.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBBreakpoint.h?rev=286631&r1=286630&r2=286631&view=diff ============================================================================== --- lldb/trunk/include/lldb/API/SBBreakpoint.h (original) +++ lldb/trunk/include/lldb/API/SBBreakpoint.h Fri Nov 11 15:06:40 2016 @@ -12,6 +12,8 @@ #include "lldb/API/SBDefines.h" +class SBBreakpointListImpl; + namespace lldb { class LLDB_API SBBreakpoint { @@ -146,8 +148,6 @@ private: lldb::BreakpointSP m_opaque_sp; }; -class SBBreakpointListImpl; - class LLDB_API SBBreakpointList { public: SBBreakpointList(SBTarget &target); Modified: lldb/trunk/include/lldb/API/SBTarget.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBTarget.h?rev=286631&r1=286630&r2=286631&view=diff ============================================================================== --- lldb/trunk/include/lldb/API/SBTarget.h (original) +++ lldb/trunk/include/lldb/API/SBTarget.h Fri Nov 11 15:06:40 2016 @@ -819,7 +819,7 @@ public: protected: friend class SBAddress; friend class SBBlock; - friend class SBBreakpointListImpl; + friend class SBBreakpointList; friend class SBDebugger; friend class SBExecutionContext; friend class SBFunction; Modified: lldb/trunk/source/API/SBBreakpoint.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBBreakpoint.cpp?rev=286631&r1=286630&r2=286631&view=diff ============================================================================== --- lldb/trunk/source/API/SBBreakpoint.cpp (original) +++ lldb/trunk/source/API/SBBreakpoint.cpp Fri Nov 11 15:06:40 2016 @@ -712,11 +712,11 @@ SBBreakpoint::GetNumBreakpointLocationsF } // This is simple collection of breakpoint id's and their target. -class lldb::SBBreakpointListImpl { +class SBBreakpointListImpl { public: - SBBreakpointListImpl(SBTarget &target) : m_target_wp() { - if (target.IsValid()) - m_target_wp = target.GetSP(); + SBBreakpointListImpl(lldb::TargetSP target_sp) : m_target_wp() { + if (target_sp && target_sp->IsValid()) + m_target_wp = target_sp; } ~SBBreakpointListImpl() = default; @@ -796,7 +796,7 @@ private: }; SBBreakpointList::SBBreakpointList(SBTarget &target) - : m_opaque_sp(new lldb::SBBreakpointListImpl(target)) {} + : m_opaque_sp(new SBBreakpointListImpl(target.GetSP())) {} SBBreakpointList::~SBBreakpointList() {} _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits