ldrumm added inline comments.
================
Comment at: scripts/Python/prepare_binding_Python.py:229
stderr=subprocess.PIPE,
- shell=True)
+ )
# Wait for SWIG process to terminate
----------------
bryant wrote:
> ldrumm wrote:
> > granata.enrico wrote:
> > > This worries me a little bit.. Are we sure we are not in any way relying
> > > on the shell in executing the command line?
> > The features of the shell are not used in this expression at all, and the
> > environment is identical to the previous invocation.
> `shell=False` for both python 2 and 3:
> https://docs.python.org/2/library/subprocess.html#subprocess.Popen ;
> https://docs.python.org/3/library/subprocess.html#subprocess.Popen , unless
> I've missed your meaning.
@bryant
> shell=False for both python 2 and 3:
> https://docs.python.org/2/library/subprocess.html#subprocess.Popen ;
> https://docs.python.org/3/library/subprocess.html#subprocess.Popen , unless
> I've missed your meaning.
Yes - the intended behaviour is to not use the shell on any python
https://reviews.llvm.org/D26757
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
