Author: ldrumm Date: Thu Dec 22 13:15:07 2016 New Revision: 290359 URL: http://llvm.org/viewvc/llvm-project?rev=290359&view=rev Log: Fix a couple of incorrect format string warnings
This patch fixes use of incorrect `%zi` to format a plain `int`, and using `%llu` to format a `uint64_t`. The fix is to use the new typesafe `llvm::Formatv` based API. Differential Revision: https://reviews.llvm.org/D28028 Subscribers: lldb-commits Modified: lldb/trunk/source/Interpreter/Args.cpp lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Modified: lldb/trunk/source/Interpreter/Args.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/Args.cpp?rev=290359&r1=290358&r2=290359&view=diff ============================================================================== --- lldb/trunk/source/Interpreter/Args.cpp (original) +++ lldb/trunk/source/Interpreter/Args.cpp Thu Dec 22 13:15:07 2016 @@ -213,10 +213,9 @@ void Args::Dump(Stream &s, const char *l int i = 0; for (auto &entry : m_entries) { s.Indent(); - s.Printf("%s[%zi]=\"%*s\"\n", label_name, i++, int(entry.ref.size()), - entry.ref.data()); + s.Format("{0}[{1}]=\"{2}\"\n", label_name, i++, entry.ref); } - s.Printf("%s[%zi]=NULL\n", label_name, i); + s.Format("{0}[{1}]=NULL\n", label_name, i); s.EOL(); } Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp?rev=290359&r1=290358&r2=290359&view=diff ============================================================================== --- lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp (original) +++ lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Thu Dec 22 13:15:07 2016 @@ -513,8 +513,8 @@ bool IRForTarget::RewriteObjCConstString default: encoding_flags = 0x0600; /* fall back to 0x0600, kCFStringEncodingASCII */ if (log) { - log->Printf("Encountered an Objective-C constant string with unusual " - "element size %llu", + log->Format("Encountered an Objective-C constant string with unusual " + "element size {0}", string_array->getElementByteSize()); } } _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits