labath wrote: Also note that there are remnants of our previous attempt at dwarf64 support (which was deleted many years ago) lying around the DWARFDataExtractor class. However, since this isn't how *llvm*'s DWARFDataExtractor works, I think we should not be using that (instead, we should delete it). LLVM's current approach is kind of similar to what you're doing actually, but instead of peppering the code with `if dwarf64` blocks, they have a function to return the correct dwarf offset size (`FormParams::getDwarfOffsetByteSize`). We should do something similar. We already have the FormParams object accessible from inside our DWARFUnit (through the m_header field), so I think it'd be best to replace `GetFormat` method you added with `GetFormParams`, and then the parsing code would do a `m_unit->GetFormParams().getDwarfOffsetByteSize`
https://github.com/llvm/llvm-project/pull/145645 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
