chelcassanova wrote:

> I'd be alright with it going in a follow-up. That being said, it would be 
> easy to kick this can down the road. Let's figure out a way to make this 
> happen without blocking this PR.

I think that this should be addressed in a follow-up PR, mainly because I think 
changes to remove this list might end up touching other parts of the SB API. 
I'd rather that the tool land and then follow up on this as it's a larger issue.

> Yes. Alternatively, let's have our internal clients move away from these so 
> we can remove it altogether 😄

Correct me if I'm wrong but we might've already done this? Either way this is 
the smallest exception list so I think I can address this still in this patch.

> Perhaps, but all of this can be done in a follow-up (unless requested by 
> another reviewer). I don't think it's essential this change right now.

Agreed.

https://github.com/llvm/llvm-project/pull/138031
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to