clayborg added a comment.

You can't add anything extra to the AsCString() since it returns a "const char 
*". You can't return a StringRef because it isn't backed by anything. You could 
return a std::string.

My vote would be to leave AsCString() alone and have it just return a pointer 
to the string buffer that it owns, and let the formatv stuff do the extra 
formatting.


https://reviews.llvm.org/D28519



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to