https://github.com/Michael137 commented:

I'm in two minds about generic formatters. It does make the implementation 
harder to follow. And is fragile to refactorings of the corresponding STL.

In this case it might be OK since you already did all the work to do so.

Side-note, I'm also a bit wary of all the cycle-detection stuff. Might be a 
remnant of protection against old libcxx bugs? We don't really do this stuff 
for other libcxx containers. Should we keep it? (CC @labath)

https://github.com/llvm/llvm-project/pull/148285
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to