labath added a comment.
Looks reasonable. To make sure things stay this way, we should make sure that
the Utility unit test has only this module specified as a dependency (I guess
after @beanz is done with digging through that).
================
Comment at: lldb/source/Target/ThreadList.cpp:387
if (log)
- log->Printf("ThreadList::%s thread 0x%4.4" PRIx64
- ": voted %s, but lost out because result was %s",
- __FUNCTION__, thread_sp->GetID(), GetVoteAsCString(vote),
- GetVoteAsCString(result));
+ log->Format(
+ __FILE__, __FUNCTION__,
----------------
Any reason for not using the log macro here? (replace `if(log) log->Format)`
with `LLDB_LOG(log, ...)`).
I did not anticipate using this function directly as the `__FILE__` , `
__FUNCTION__` thingies make it very obnoxious.
https://reviews.llvm.org/D29359
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
