kubamracek added inline comments.
================ Comment at: source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89 + + void *dlsym(void* handle, const char* symbol); + int (*ptr__tsan_get_report_loc_object_type)(void *report, unsigned long idx, const char **object_type); ---------------- clayborg wrote: > kubamracek wrote: > > clayborg wrote: > > > Doesn't "dlsym" work on all platforms? Windows? > > Right, it probably doesn't work on Windows. I'll put in a FIXME/TODO (TSan > > currenly only works on POSIX anyway), okay? > Now worries, you can also #ifdef around it if needed and put the code needed > for windows right in the expression text here. Does TSAN current work on > Windows? If so it seems like bug to not support this feature on windows? TSan doesn't work on Windows. https://reviews.llvm.org/D30024 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
