labath accepted this revision. labath added a comment. lgtm, thanks.
================ Comment at: packages/Python/lldbsuite/test/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/main.cpp:30 + + hw_break_mutex.lock(); + ---------------- I know it's only a test program, but you generally should never lock the mutex manually. `std::lock_guard<std::mutex> guard(mutex)` https://reviews.llvm.org/D29669 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits