Nerixyz wrote: > Since the only difference in the reverted patch was adding `AsmLabel`s to the > PDB decls, I'd be curious to see what those `AsmLabel`s look like on mingw32?
This wasn't reverted in https://github.com/llvm/llvm-project/commit/185ae5cdc695248b58ae017508cc764c19bee5b7 - it was the function naming. > Have we not tried creating `Mangled` objects from mingw32 mangled names prior > to your reverted patch? I'd be surprised, but maybe it truly is the first > time it was required? Surprised me as well, but now that I think about it, it does make sense: We only use `Mangled` in the native plugin for function creation, where we (currently) use the demangled name. And before https://github.com/llvm/llvm-project/pull/154121, public symbols from the PDB were not included. Only the DIA plugin used the mangled name (if available), but that's not used on MinGW builds. https://github.com/llvm/llvm-project/pull/160930 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
