jimingham wrote: It makes sense to clear the "next branch" breakpoint there. Either the thread plan's next branch breakpoint was the only one we hit, in which case that part of the step succeeded and we should clear that breakpoint, or there was a user breakpoint there and we're going to give control back to the user, in which case, again, clearing the breakpoint is a good idea.
I think not doing this would be pretty hard to notice. We will delete the breakpoint when the thread plan is destroyed, so it won't outlive the stepping sequence. Did you actually have a case where this fails, or was this just code inspection? Anyway, it's worth waiting a bit for a reply by the patch author, but this LGTM. https://github.com/llvm/llvm-project/pull/161597 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
