https://github.com/JDevlieghere approved this pull request.
LGTM, there's really not that much actual new code to review. The code duplication is unfortunate but I don't think that should stand in the way of a more ergonomic command. Could we add a big warning at the top of the old and new file to remind folks to at least try to keep the two in sync for now? I left some comments for improvements, though I realize this is all pre-existing code. We would be better off addressing it for both the old and new implementation in a follow up PR. https://github.com/llvm/llvm-project/pull/156067 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
