dmpots wrote: > We could also just remove the typedef, as it doesn't tell the reader anything > about the type; DEARFExpression::Stack is trying to say what the variable is > supposed to be (which is better captured by the variable name), not how the > concrete type behaves.
I think the typedef is still useful because it ties it back to the dwarf expression evaluation. The context is useful because we know that the stack being passed is the dwarf expression stack. It's not the fact that it is a *stack* that is useful, but that it is the *dwarf expression* stack. https://github.com/llvm/llvm-project/pull/167018 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
