kettenis added a comment.

The core file reading bits look ok to me.



================
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:383
   // On Linux the executable is indicated by an empty path in the entry. On
   // FreeBSD and on Android it is the full path to the executable.
 
----------------
Probably should update this comment


================
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:456
+}
+
 // Parse a FreeBSD NT_PRSTATUS note - see FreeBSD sys/procfs.h for details.
----------------
Unfortunate that the note numbers are different from architecture to 
architecture on NetBSD.


Repository:
  rL LLVM

https://reviews.llvm.org/D31450



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to